Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: deprecate process.EventEmitter #5049

Merged
merged 1 commit into from
Feb 4, 2016
Merged

node: deprecate process.EventEmitter #5049

merged 1 commit into from
Feb 4, 2016

Conversation

evanlucas
Copy link
Contributor

The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to actually deprecate it.

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Feb 3, 2016
@mscdex
Copy link
Contributor

mscdex commented Feb 3, 2016

/cc @ChALkeR

Does anyone use this anywhere?

@evanlucas
Copy link
Contributor Author

FWIW here is a github search for it as well. https://github.com/search?p=2&q=process.EventEmitter&type=Code&utf8=%E2%9C%93

@jasnell
Copy link
Member

jasnell commented Feb 3, 2016

LGTM

1 similar comment
@bnoordhuis
Copy link
Member

LGTM

@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1524/

Was the decision that we could deprecate in a minor version, or did we go with major?

@ChALkeR
Copy link
Member

ChALkeR commented Feb 3, 2016

@mscdex This is used, though the usage is not high. Will post a list a bit later today.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2016

LGTM

1 similar comment
@thefourtheye
Copy link
Contributor

LGTM

@silverwind
Copy link
Contributor

@evanlucas you can get better results by quoting.

@evanlucas
Copy link
Contributor Author

oh nice

@ChALkeR
Copy link
Member

ChALkeR commented Feb 4, 2016

https://gist.github.com/ChALkeR/232fdf64be9c34c9c733, sorted by downloads count per month.
The first entry (array-difference) looks like a false positive to me.

I'm +1 for deprecating this, but in a semver-major, of course.

@ChALkeR ChALkeR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 4, 2016
@evanlucas
Copy link
Contributor Author

Major works for me

@Fishrock123 Fishrock123 added this to the 6.0.0 milestone Feb 4, 2016
@silverwind
Copy link
Contributor

LGTM, looks to be low-impact.

@evanlucas
Copy link
Contributor Author

CI https://ci.nodejs.org/job/node-test-pull-request/1550/ one more time before landing since the last one was red.

@evanlucas
node: deprecate process.EventEmitter
25751be 
The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to
actually deprecate it.

PR-URL: nodejs#5049
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@evanlucas evanlucas closed this Feb 4, 2016
@evanlucas evanlucas deleted the depee branch February 4, 2016 19:45
@evanlucas evanlucas merged commit 25751be into nodejs:master Feb 4, 2016
@evanlucas
Copy link
Contributor Author

Landed in 25751be. Thanks

@Cangit Cangit mentioned this pull request Feb 11, 2016
Closed
@jasnell jasnell mentioned this pull request Mar 17, 2016
Closed
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@evanlucas
node: deprecate process.EventEmitter
6b95c87 
The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to
actually deprecate it.

PR-URL: nodejs#5049
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@cjihrig cjihrig mentioned this pull request May 18, 2016
Closed
2 tasks
@ChALkeR ChALkeR mentioned this pull request May 18, 2016
Closed
cjihrig added a commit that referenced this pull request May 24, 2016
@cjihrig
process: remove deprecated process.EventEmitter
62b5442 
process.EventEmitter was deprecated for v6. This commit removes
it for v7.

Refs: #5049
PR-URL: #6862
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 24, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
9 participants
@evanlucas @mscdex @jasnell @bnoordhuis @ChALkeR @cjihrig @thefourtheye @silverwind @Fishrock123