test: scope redeclared vars in test-child-process* #4944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations.
Trott
added
child_process
|
lts watch label applied. Hey @Trott , can I ask you to please attach the lts-watch label to these kinds of test updates? It would save a ton of time :-) |
| @@ -42,7 +42,7 @@ if (process.argv[2] === 'child') { | |||
| }); | |||
|
|
|||
| } else { | |||
| var server = dgram.createSocket('udp4'); | |||
| server = dgram.createSocket('udp4'); | |||
There was a problem hiding this comment.
Could you declare the variable outside of the if block ?
Edit: I mean move the declaration.
|
LGTM with a comment. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 1, 2016
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: nodejs#4944 Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 185f849 |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: #4944 Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: #4944 Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: #4944 Reviewed-By: Michaël Zasso <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: #4944 Reviewed-By: Michaël Zasso <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: nodejs#4944 Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of child process tests had variables declared multiple times
in the same scope using
var. This change scopes those declarations.