Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reserve 117 for Electron 26 #48245

Merged
merged 1 commit into from
May 31, 2023
Merged

doc: reserve 117 for Electron 26 #48245

merged 1 commit into from
May 31, 2023

Conversation

clavin
Copy link
Contributor

@clavin clavin commented May 29, 2023

This PR reserves NMV 117 for Electron 26

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 29, 2023
@targos targos added fast-track PRs that do not need to wait for 48 hours to land. dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels May 30, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 82397c0 into nodejs:main May 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 82397c0

targos pushed a commit that referenced this pull request Jun 4, 2023
@clavin @targos
doc: reserve 117 for Electron 26
96e54dd 
PR-URL: #48245
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@clavin @Ceres6
doc: reserve 117 for Electron 26
435a52f 
PR-URL: nodejs#48245
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@clavin @Ceres6
doc: reserve 117 for Electron 26
1bd8a1d 
PR-URL: nodejs#48245
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@clavin @nodejs-github-bot @lpinca @targos @tniessen @richardlau @MoLow