test: refactor test-net-settimeout #4799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-net-settimeout is unnecessarily complex. This change simplifies it.
Trott
added
net
|
LGTM if CI is ok: https://ci.nodejs.org/job/node-test-pull-request/1348/ |
|
☝️ What he said, LGTM |
|
CI looks good in that failures are a known flaky test (that has since been removed) and a bunch of buildbot problems. Let's try again to see if we get something a little cleaner: |
|
Irksomely, the only failure was a Windows buildbot failure that just happened to be one of the ones that would run this settimeout test. Trying a third CI because that is what I do: https://ci.nodejs.org/job/node-test-pull-request/1366/ |
|
Last CI buildbot failures were on fanned machines not slated to run this test, so we're all set. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 26, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: nodejs#4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
|
Landed in 457a1ca |
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: #4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: nodejs#4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: #4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: #4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: #4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: #4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it. PR-URL: nodejs#4799 Reviewed-By: Brian White <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 19, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-net-settimeout is unnecessarily complex. This change simplifies it.