Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix setEngine() when OPENSSL_NO_ENGINE set #47977

Merged
merged 1 commit into from
May 15, 2023
Merged

crypto: fix setEngine() when OPENSSL_NO_ENGINE set #47977

merged 1 commit into from
May 15, 2023

Commits on May 12, 2023

  1. crypto: fix setEngine() when OPENSSL_NO_ENGINE set 

    When OpenSSL is configured with OPENSSL_NO_ENGINE, setEngine() currently
throws an internal error because the C++ binding does not export the
relevant function, which causes _setEngine() to be undefined within JS.

Instead, match the behavior of tls/secure-context.js and throw the
existing error code ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED when OpenSSL
has been configured with OPENSSL_NO_ENGINE.
    @tniessen
    tniessen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    742bd83 View commit details
    Browse the repository at this point in the history