test_runner: add testNamePatterns to run api #47628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
atlowChemi
force-pushed
the
test_runner--add-name-patterns-to-run-api
branch
from
3fb7c7e
to
c7c46e2
Compare
ljharb
reviewed
Apr 19, 2023
atlowChemi
force-pushed
the
test_runner--add-name-patterns-to-run-api
branch
from
c7c46e2
to
fa9f118
Compare
atlowChemi
force-pushed
the
test_runner--add-name-patterns-to-run-api
branch
from
fa9f118
to
72137fd
Compare
MoLow
reviewed
Apr 20, 2023
Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. Fixes: nodejs#46045
atlowChemi
force-pushed
the
test_runner--add-name-patterns-to-run-api
branch
from
72137fd
to
dea6914
Compare
MoLow
approved these changes
Apr 20, 2023
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Apr 23, 2023
MoLow
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47628 ✔ Done loading data for nodejs/node/pull/47628 ----------------------------------- PR info ------------------------------------ Title test_runner: add testNamePatterns to run api (#47628) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch atlowChemi:test_runner--add-name-patterns-to-run-api -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: add testNamePatterns to run api Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/47628 Fixes: https://github.com/nodejs/node/issues/46045 Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47628 Fixes: https://github.com/nodejs/node/issues/46045 Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 19 Apr 2023 22:29:54 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47628#pullrequestreview-1394841197 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47628#pullrequestreview-1396865473 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-23T06:53:39Z: https://ci.nodejs.org/job/node-test-pull-request/51426/ - Querying data for job/node-test-pull-request/51426/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47628 From https://github.com/nodejs/node * branch refs/pull/47628/merge -> FETCH_HEAD ✔ Fetched commits as dbf71e509c72..dea691403b25 -------------------------------------------------------------------------------- [main 1735ca6b7d] test_runner: add testNamePatterns to run api Author: atlowChemi Date: Thu Apr 20 00:16:57 2023 +0200 4 files changed, 63 insertions(+), 7 deletions(-) create mode 100644 test/fixtures/test-runner/test/skip_by_name.cjs ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/46045' is present and should be a trailer.https://github.com/nodejs/node/actions/runs/4777711253 |
MoLow
added
commit-queue
|
Landed in c627969 |
|
@benjamingr it seems like there as been a commit pushed already |
cjihrig
referenced
this pull request
Apr 23, 2023
Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. PR-URL: #47648 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
@MoLow The issue was not auto-closed FYI |
This was referenced Apr 24, 2023
targos
added
the
semver-minor
targos
added a commit
that referenced
this pull request
May 3, 2023
Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820
targos
added a commit
that referenced
this pull request
May 3, 2023
Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept a
testNamePatternsvalue in therunfn, and drill those patterns to the spawned processes.Fixes: #46045