Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12 backport] deps: V8: cherry-pick cc9a8a37445e #42065

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[v12 backport] deps: V8: cherry-pick cc9a8a37445e #42065

merged 1 commit into from
Mar 30, 2022

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Feb 20, 2022

Original commit message:

fix overflow check in error formatting

Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Gus Caplan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#78909}

Refs: v8/v8@cc9a8a3

@devsnek
deps: V8: cherry-pick cc9a8a37445e
d973691 
Original commit message:

    fix overflow check in error formatting

    Bug: v8:12494
    Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Gus Caplan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78909}

Refs: v8/v8@cc9a8a3
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@devsnek devsnek changed the title [v14 backport] deps: V8: cherry-pick cc9a8a37445e [v12 backport] deps: V8: cherry-pick cc9a8a37445e Feb 20, 2022
@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Feb 20, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 20, 2022 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/42704/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4522/

@richardlau richardlau merged commit 1193290 into v12.x-staging Mar 30, 2022
@richardlau
Copy link
Member

Landed in 1193290.

@richardlau richardlau deleted the cherrypick-41823-12x branch March 30, 2022 12:42
@richardlau richardlau mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@aduh95 aduh95 aduh95 approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@devsnek @nodejs-github-bot @richardlau @Trott @gengjiawen @aduh95 @DerekNonGeneric @RaisinTen @Mesteery