dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion #41431

aduh95 · 2022-01-07T16:26:44Z

No description provided.

nodejs-github-bot · 2022-01-07T16:26:48Z

Review requested:

@nodejs/net

doc/api/deprecations.md

nodejs-github-bot · 2022-04-03T17:29:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43296/

nodejs-github-bot · 2022-04-03T19:39:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43301/

aduh95 · 2022-04-03T19:55:22Z

@nodejs/tsc can we get this into v18.x?

Trott

LGTM if CITGM doesn't find problems.

mcollina · 2022-04-03T20:18:49Z

src/node_os.cc

    } else if (interfaces[i].address.address4.sin_family == AF_INET6) {
      uv_ip6_name(&interfaces[i].address.address6, ip, sizeof(ip));
      uv_ip6_name(&interfaces[i].netmask.netmask6, netmask, sizeof(netmask));
-      family = env->ipv6_string();
+      family = Integer::New(env->isolate(), 6);


I'm concerned about these two specific changes, moving from IPv4 to 4 and IPv6 to 6. I'm 100% sure those will break some of my modules (Fastify v4).

The reason for this change is that currently passing an address object to the DNS resolver, the 'IPv6' string is converted to 0.
Would it be reasonable to ask you to update the code that using that to expect one form or the other? Something like info.family === 6 || info.family === 'IPv6'? If not, we could make the DNS resolver accept a string and interpret 'IPv6' same as 6.

I assume this change will hurt the community a lot.

I personally would see this:

If not, we could make the DNS resolver accept a string and interpret 'IPv6' same as 6.

as the better solution

Agreed here. I realize that Node v18 was a major version change, but changing the output of a widely used API (socket.address()) just so another core-Node API could match up with it instead of making the DNS resolver more flexible seems pretty overkill!

Now that it's out in the wild, can confirm it caused some widespread breaking for us that's going to make node 18 a pain and very uncertain to roll out.

I assume this change will hurt the community a lot.

Can confirm completely unexpected breakage

@aduh95 @mcollina Any chance to think about that change again and consider alternatives?

maybe a new issue is more visible to the nodejs team and allows a better discussion ... so see #43014 ... Please "thumbs up" it if you support to adjust this to be backward compatible. Thank you

mcollina

lgtm

aduh95 · 2022-04-04T13:36:29Z

CITGM (master): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2904/
CITGM (aduh95:no-dns-lookup-options-type-coercion): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2905/

nodejs-github-bot · 2022-04-06T22:14:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43357/

nodejs-github-bot · 2022-04-08T10:11:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43390/

richardlau · 2022-04-08T14:06:16Z

@aduh95 If it helps the failures in the recent CI runs for this PR have all been running inside containers.

nodejs-github-bot · 2022-04-08T18:19:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43400/

nodejs-github-bot · 2022-04-08T18:22:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43401/

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in nodejs#41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in nodejs#41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in nodejs#42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in nodejs#42292, nodejs#42604 and nodejs#42659 , and Michaël Zasso in nodejs#42105 and nodejs#42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in nodejs#42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in nodejs#39062, and Antoine du Hamel in nodejs#42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (nodejs#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (nodejs#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (nodejs#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (nodejs#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (nodejs#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (nodejs#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (nodejs#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (nodejs#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (nodejs#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (nodejs#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (nodejs#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (nodejs#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (nodejs#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (nodejs#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (nodejs#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (nodejs#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (nodejs#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (nodejs#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (nodejs#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (nodejs#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (nodejs#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (nodejs#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (nodejs#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (nodejs#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (nodejs#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (nodejs#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (nodejs#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (nodejs#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (nodejs#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (nodejs#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (nodejs#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (nodejs#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) PR-URL: nodejs#42262

Refs: nodejs#41431 Fixes: nodejs#42787 PR-URL: nodejs#42789 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>

Context: nodejs/node#41431 (comment)

Refs: #41431 Fixes: #42787 PR-URL: #42789 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>

Refs: #41431 PR-URL: #42795 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Context: nodejs/node#41431 (comment)

ref: #8530 See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

Refs: #41431 PR-URL: #42795 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 7, 2022

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 7, 2022

VoltrexKeyva reviewed Jan 8, 2022

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

aduh95 force-pushed the no-dns-lookup-options-type-coercion branch from 740a691 to 8e53d29 Compare April 3, 2022 17:08

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2022

aduh95 force-pushed the no-dns-lookup-options-type-coercion branch from 8e53d29 to 13c8788 Compare April 3, 2022 19:39

Trott approved these changes Apr 3, 2022

View reviewed changes

mcollina reviewed Apr 3, 2022

View reviewed changes

mcollina approved these changes Apr 4, 2022

View reviewed changes

aduh95 force-pushed the no-dns-lookup-options-type-coercion branch from 13c8788 to 84164de Compare April 4, 2022 13:31

mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 4, 2022

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 6, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2022

This was referenced Apr 7, 2022

CI Reliability 2022-04-07 nodejs/reliability#244

Open

CI Reliability 2022-04-08 nodejs/reliability#245

Open

aduh95 marked this pull request as draft April 8, 2022 10:11

Supereg mentioned this pull request Apr 25, 2022

fixes #945 homebridge/HAP-NodeJS#946

Closed

IvanGoncharov added a commit to IvanGoncharov/DefinitelyTyped that referenced this pull request Apr 25, 2022

fix(node): in node@18 'AddressInfo.family' is number

7adf603

Context: nodejs/node#41431 (comment)

IvanGoncharov mentioned this pull request Apr 25, 2022

fix(node): in node@18 'AddressInfo.family' is number DefinitelyTyped/DefinitelyTyped#60042

Closed

8 tasks

IvanGoncharov added a commit to IvanGoncharov/apollo-server that referenced this pull request Apr 25, 2022

test: fix failing integration tests on node@18

df7dbb8

Context: nodejs/node#41431 (comment)

IvanGoncharov mentioned this pull request Apr 25, 2022

test: fix failing integration tests on node@18 apollographql/apollo-server#6350

Merged

Apollon77 mentioned this pull request Apr 25, 2022

Error on Node 18 indutny/node-ip#113

Closed

oznu mentioned this pull request Apr 26, 2022

Fix #945 - Node.js v18 os.networkInterfaces()[].family number/string comparison homebridge/HAP-NodeJS#947

Merged

IvanGoncharov added a commit to IvanGoncharov/apollo-server that referenced this pull request Apr 26, 2022

test: fix failing integration tests on node@18

29a2a7f

Context: nodejs/node#41431 (comment)

oznu mentioned this pull request Apr 27, 2022

Fix #18 - Node.js v18 os.networkInterfaces()[].family number/string c… homebridge/ciao#25

Merged

nodejs-github-bot pushed a commit that referenced this pull request Apr 28, 2022

test: fix parallel/test-dgram-udp6-link-local-address

68fb0bf

Refs: #41431 PR-URL: #42795 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

glasser pushed a commit to IvanGoncharov/apollo-server that referenced this pull request Apr 28, 2022

test: fix failing integration tests on node@18

494c15b

Context: nodejs/node#41431 (comment)

trevor-scheer pushed a commit to apollographql/apollo-server that referenced this pull request Apr 28, 2022

test: fix failing integration tests on node@18 (#6350)

6cd417c

Context: nodejs/node#41431 (comment)

miherlosev mentioned this pull request Apr 29, 2022

Testcafe doesn't work with node 18.0 DevExpress/testcafe#7000

Closed

bluwy mentioned this pull request Apr 29, 2022

fix: display network logs in node 18 sveltejs/kit#4778

Merged

5 tasks

frbuceta added a commit to loopbackio/loopback-next that referenced this pull request May 1, 2022

chore: pin eslint-plugin-mocha dependency to 10.0.3

af11da6

ref: #8530 See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

frbuceta added a commit to loopbackio/loopback-next that referenced this pull request May 1, 2022

chore: pin eslint-plugin-mocha dependency to 10.0.3

0979f81

ref: #8530 See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

frbuceta added a commit to loopbackio/loopback-next that referenced this pull request May 2, 2022

fix: address.family is number in Node v18

e45cafa

See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

targos pushed a commit that referenced this pull request May 2, 2022

test: fix parallel/test-dgram-udp6-link-local-address

3c796f8

Refs: #41431 PR-URL: #42795 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

frbuceta added a commit to loopbackio/loopback-next that referenced this pull request May 3, 2022

fix: address.family is number in Node v18

9758ba8

See nodejs/node#41431 Signed-off-by: Francisco Buceta <[email protected]>

panva mentioned this pull request May 3, 2022

os.networkInterfaces().family is no longer a string #42953

Closed

Apollon77 mentioned this pull request May 9, 2022

Revert the change of network interfaces family from String to Integer #43014

Closed

nodech mentioned this pull request May 11, 2022

Localhost lookup and default host settings handshake-org/hsd#722

Closed

JKRhb mentioned this pull request May 22, 2022

chore: update tested node versions to 14, 16, and 18 coapjs/node-coap#347

Merged

RaisinTen mentioned this pull request Sep 29, 2022

net: add autoSelectFamily option #44731

Merged

ksmithut mentioned this pull request Nov 2, 2022

Node 18 family parameter fails when passing url redis/ioredis#1672

Closed

climba03003 mentioned this pull request Sep 16, 2024

dns.lookup options..family throw errors when using 'IPv4' #54961

Closed

RedYetiDev mentioned this pull request Sep 16, 2024

doc: remove outdated sentence #54963

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion #41431

dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion #41431

aduh95 commented Jan 7, 2022

nodejs-github-bot commented Jan 7, 2022

nodejs-github-bot commented Apr 3, 2022

nodejs-github-bot commented Apr 3, 2022

aduh95 commented Apr 3, 2022

Trott left a comment

mcollina Apr 3, 2022

aduh95 Apr 3, 2022

Apollon77 Apr 25, 2022 •

edited

Loading

glasser Apr 28, 2022

aredridel May 5, 2022

Hypfer May 7, 2022

Apollon77 May 7, 2022

Apollon77 May 9, 2022

mcollina left a comment

aduh95 commented Apr 4, 2022

nodejs-github-bot commented Apr 6, 2022

nodejs-github-bot commented Apr 8, 2022

richardlau commented Apr 8, 2022

nodejs-github-bot commented Apr 8, 2022

nodejs-github-bot commented Apr 8, 2022

dns: remove dns.lookup and dnsPromises.lookup options type coercion #41431

dns: remove dns.lookup and dnsPromises.lookup options type coercion #41431

Conversation

aduh95 commented Jan 7, 2022

nodejs-github-bot commented Jan 7, 2022

nodejs-github-bot commented Apr 3, 2022

nodejs-github-bot commented Apr 3, 2022

aduh95 commented Apr 3, 2022

Trott left a comment

Choose a reason for hiding this comment

mcollina Apr 3, 2022

Choose a reason for hiding this comment

aduh95 Apr 3, 2022

Choose a reason for hiding this comment

Apollon77 Apr 25, 2022 • edited Loading

Choose a reason for hiding this comment

glasser Apr 28, 2022

Choose a reason for hiding this comment

aredridel May 5, 2022

Choose a reason for hiding this comment

Hypfer May 7, 2022

Choose a reason for hiding this comment

Apollon77 May 7, 2022

Choose a reason for hiding this comment

Apollon77 May 9, 2022

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

aduh95 commented Apr 4, 2022

nodejs-github-bot commented Apr 6, 2022

nodejs-github-bot commented Apr 8, 2022

richardlau commented Apr 8, 2022

nodejs-github-bot commented Apr 8, 2022

nodejs-github-bot commented Apr 8, 2022

dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion #41431

dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion #41431

Apollon77 Apr 25, 2022 •

edited

Loading