From 37a1a3c4a380de18032a82050c4a95781251c592 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 17 Nov 2021 16:58:02 -0800 Subject: [PATCH 1/2] stream: fix the ReadableStreamBYOBReader error message --- lib/internal/webstreams/readablestream.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js index fe9b26b991f04e..c9b988d6fee0f7 100644 --- a/lib/internal/webstreams/readablestream.js +++ b/lib/internal/webstreams/readablestream.js @@ -508,6 +508,8 @@ class ReadableStream { return customInspect(depth, options, this[kType], { locked: this.locked, state: this[kState].state, + supportsBYOB: + this[kState].controller instanceof ReadableByteStreamController, }); } @@ -1745,7 +1747,7 @@ function setupReadableStreamBYOBReader(reader, stream) { controller, } = stream[kState]; if (!isReadableByteStreamController(controller)) - throw new ERR_INVALID_ARG_VALUE('reader', reader, 'must be a byte stream'); + throw new ERR_INVALID_ARG_VALUE('stream', stream, 'must be a byte stream'); readableStreamReaderGenericInitialize(reader, stream); reader[kState].readIntoRequests = []; } From ea209ffa7cf6327e864a2a74ff73ee2ba7a5665b Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 18 Nov 2021 08:16:31 -0800 Subject: [PATCH 2/2] fixup! stream: fix the ReadableStreamBYOBReader error message --- test/parallel/test-whatwg-readablestream.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-whatwg-readablestream.js b/test/parallel/test-whatwg-readablestream.js index c8b82fa9823786..ce1d892262be16 100644 --- a/test/parallel/test-whatwg-readablestream.js +++ b/test/parallel/test-whatwg-readablestream.js @@ -1410,10 +1410,12 @@ class Source { assert.strictEqual( inspect(readable), - 'ReadableStream { locked: false, state: \'readable\' }'); + 'ReadableStream { locked: false, state: \'readable\', ' + + 'supportsBYOB: false }'); assert.strictEqual( inspect(readable, { depth: null }), - 'ReadableStream { locked: false, state: \'readable\' }'); + 'ReadableStream { locked: false, state: \'readable\', ' + + 'supportsBYOB: false }'); assert.strictEqual( inspect(readable, { depth: 0 }), 'ReadableStream [Object]');