From 2992012556dc3ed2df90495bba4b88d972671f98 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 28 Nov 2015 14:38:15 -0800
Subject: [PATCH] test: refactor flaky net-error-twice

The test was not reliably creating the error event on Windows 2012.

This makes the test more robust by delaying the start of the server
write until nextTick, allowing the connection to close and cause the
error more reliably on Windows 2012.

Fixes: https://github.com/nodejs/node/issues/4057
---
 test/parallel/test-net-error-twice.js | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/test/parallel/test-net-error-twice.js b/test/parallel/test-net-error-twice.js
index af92ca93206f18..4e9793e1f420ca 100644
--- a/test/parallel/test-net-error-twice.js
+++ b/test/parallel/test-net-error-twice.js
@@ -1,33 +1,29 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var net = require('net');
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
 
-var buf = new Buffer(10 * 1024 * 1024);
+const buf = new Buffer(10 * 1024 * 1024);
 
 buf.fill(0x62);
 
 var errs = [];
 
-var srv = net.createServer(function onConnection(conn) {
-  conn.write(buf);
+const srv = net.createServer(function onConnection(conn) {
+  process.nextTick(() => { conn.write(buf); });
   conn.on('error', function(err) {
     errs.push(err);
-    if (errs.length > 1 && errs[0] === errs[1])
-      assert(false, 'We should not be emitting the same error twice');
+    if (errs.length > 1)
+      assert(errs[0] !== errs[1], 'Should not get the same error twice');
   });
   conn.on('close', function() {
     srv.unref();
   });
 }).listen(common.PORT, function() {
-  var client = net.connect({ port: common.PORT });
-
-  client.on('connect', function() {
-    client.destroy();
-  });
+  const client = net.connect({ port: common.PORT });
+  client.on('connect', client.destroy);
 });
 
 process.on('exit', function() {
-  console.log(errs);
   assert.equal(errs.length, 1);
 });