Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Timers #4007

Closed
wants to merge 29 commits into from
Closed

Refactor Timers #4007

wants to merge 29 commits into from

Commits on Feb 25, 2016

  1. timers: refactor timers 

    Consolidates the implementation of regular and internal (_unrefActive)
timers.

Includes an optimization for listOnTimeout() that previously only
internal timers had. (_runOnTimeout)

Also includes some minor other cleanup.
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    d171259 View commit details
    Browse the repository at this point in the history

  2. timers: greatly improve code comments 

    Describes the How and Why of the timers implementation, as well as
adding comments in spots that should allow for an easier understanding
of what is going on.

The timers implementation is very efficient, at a cost.
That cost is readable understandability, and this aims to improve that.
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    ba5fd2c View commit details
    Browse the repository at this point in the history

  3. timers: (fixup) refactor insert a bit more 

    See: nodejs#4007 (comment)
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    b9870e1 View commit details
    Browse the repository at this point in the history

  4. timers: (fixup) remove some more unnecessary indentation

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    acb53d0 View commit details
    Browse the repository at this point in the history

  5. timers: (fixup) fix my understanding of how timers work

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    6493176 View commit details
    Browse the repository at this point in the history

  6. timers: (fixup) handle domains properly again

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    e8db191 View commit details
    Browse the repository at this point in the history

  7. timers: (fixup) clean up code comments

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    189c148 View commit details
    Browse the repository at this point in the history

  8. timers: (fixup) correct domains dispose thing

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    339ee8c View commit details
    Browse the repository at this point in the history

  9. timers: (fixup) address bnoordhuis nits

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    234b580 View commit details
    Browse the repository at this point in the history

  10. timers: (fixup) some more nits

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    7e6bb6d View commit details
    Browse the repository at this point in the history

  11. timers: (fixup) fix message test

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    65a2c8f View commit details
    Browse the repository at this point in the history

  12. timers: (fixup) add a debuglog statement

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    c3cb939 View commit details
    Browse the repository at this point in the history

  13. timers: (fixup) rvagg's list optimization 

    Prevents the JS representation of TimerWraps from deopting from being a
linked list.
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    298d30f View commit details
    Browse the repository at this point in the history

  14. timers: (fixup) Update code comments. 

    I am going to hate squashing this.
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    93e29e1 View commit details
    Browse the repository at this point in the history

  15. timers: (fixup) rename Timer to TimerWrap 

    Eliminate this confusion once and for all. Only ever refer to the C++
handles as “TimerWrap(s)”.
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    aa31fef View commit details
    Browse the repository at this point in the history

  16. timers: (fixup) spelling nits

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    61dd4ab View commit details
    Browse the repository at this point in the history

  17. timers: (fixup) remove "active" comment 

    I dunno how to make this comment useful…
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    06ab42e View commit details
    Browse the repository at this point in the history

  18. timers: (fixup) fix comment

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    aaf7e26 View commit details
    Browse the repository at this point in the history

  19. timers: (fixup) move a code comment

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    e28efc9 View commit details
    Browse the repository at this point in the history

  20. timers: (fixup) address most of Julien's comments

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    739f9ea View commit details
    Browse the repository at this point in the history

  21. timers: (fixup) nit

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    d86edc9 View commit details
    Browse the repository at this point in the history

  22. timers: (fixup) remove ascii drawing :( 

    node refuses to compile with it
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    5d9cc35 View commit details
    Browse the repository at this point in the history

  23. timers: (fixup) remove _ in tryOnTimeout 

    rename to match Brian’s setImmediate() refactor in
nodejs#4169
    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    4120c5e View commit details
    Browse the repository at this point in the history

  24. timers: (fixup) re-add awesome diagram

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    11a96ad View commit details
    Browse the repository at this point in the history

  25. timers: (fixup) update comment preface

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    13b2e0c View commit details
    Browse the repository at this point in the history

  26. timers: (fixup) final? spelling nits

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    1acab4d View commit details
    Browse the repository at this point in the history

  27. timers: (fixup) fix linting

    @Fishrock123
    Fishrock123 committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    dc0961e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2016

  1. timers: (fixup) use a constructor function for lists

    @Fishrock123
    Fishrock123 committed Feb 26, 2016
    Configuration menu
    Copy the full SHA
    a7d3be5 View commit details
    Browse the repository at this point in the history

  2. timers: (fixup) update ascii graph for TimersList

    @Fishrock123
    Fishrock123 committed Feb 26, 2016
    Configuration menu
    Copy the full SHA
    c87e455 View commit details
    Browse the repository at this point in the history