test: skip test if FreeBSD jail will break it

[Trott]

test/internet/test-dgram-broadcast-multi-process.js fails if it is in a FreeBSD jail. This issue is with the way FreeBSD jails work and not with Node. Skip the test if in a FreeBSD jail.

[jbergstroem]

Suggestion: Perhaps add a comment/reference to the issue(s) we've been having.

LGTM.

[Trott]

@jbergstroem I added it in the Fixes: metadata field in the commit message and force pushed. Does that work?

For reference (for anyone who doesn't want to switch to the commit message tab), it's #2472

[jbergstroem]

All good.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/740/

Unfortunately, that CI doesn't exercise the code change (other than linting it) because internet tests are skipped in CI. So here's a CI run for FreeBSD only where the Makefile was altered to run the internet tests: https://ci.nodejs.org/job/node-test-commit-freebsd/303/

@jbergstroem The results of that CI run lead me to believe that freebsd102-64 is not in a jail. Is that right? (Because if it is, then common.inFreeBSDJail isn't picking up on that....)

[jbergstroem]

@Trott correct, freebsd102-64 is a vm at digitalocean.

[Trott]

Unfortunately, the test fails there too. The only difference is that this new code doesn't cause it to be skipped. :-/

[jbergstroem]

Thats the FreeBSD machine at joyent (not a jail). Shouldn't matter though. I can have a look later, but broadcast is properly responding at 255.255.255.255.

[jasnell]

LGTM

[bnoordhuis]

Not that you need it but have another LGTM.

[jasnell]

Landed in a2144fc