Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 8.4.371.23 #38001

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 8.4.371.23 #38001

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 31, 2021

Refs: v8/v8@8.4.371.19...8.4.371.23

Some old fixes that we never applied.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v14.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 31, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37075/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3888/

mhdawson
mhdawson approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37106/

targos added a commit that referenced this pull request Apr 3, 2021
@targos
deps: patch V8 to 8.4.371.23
11505ad 
Refs: v8/v8@8.4.371.19...8.4.371.23

PR-URL: #38001
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos
Copy link
Member Author

targos commented Apr 3, 2021

Landed in 11505ad

@targos targos closed this Apr 3, 2021
@targos targos deleted the update-v8-8.4.371.23 branch April 3, 2021 12:28
@bcoe bcoe mentioned this pull request Apr 5, 2021
Closed
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
@targos @MylesBorins
deps: patch V8 to 8.4.371.23
6b115d7 
Refs: v8/v8@8.4.371.19...8.4.371.23

PR-URL: #38001
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @cjihrig @gengjiawen @richardlau @mhdawson