Revert 36635 #37964
Closed
Revert 36635 #37964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2da3611. See: nodejs#37937
nodejs-github-bot
added
http
ronag
approved these changes
Mar 29, 2021
dnlup
approved these changes
Mar 29, 2021
jasnell
approved these changes
Mar 29, 2021
mscdex
reviewed
Mar 29, 2021
lpinca
approved these changes
Mar 29, 2021
|
The added test seems overcomplicated. I spotted the same leak issue here: #37291 (comment). So I think we can simply add |
|
@lpinca good spot, updated |
targos
approved these changes
Mar 29, 2021
cjihrig
approved these changes
Mar 30, 2021
lpinca
pushed a commit
that referenced
this pull request
Mar 31, 2021
This reverts commit 2da3611. PR-URL: #37964 Refs: #37937 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
lpinca
pushed a commit
that referenced
this pull request
Mar 31, 2021
PR-URL: #37964 Refs: #37937 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 3dee233...31fe3b2. |
|
Adding don't land labels as the original commit did not land on and of the release branches yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #37937 for more details.
This revers a commit that caused an unlimited amount of event listener added to a socket when receiving HTTP pipelining, causing a memory leak.
It also adds a test a second commit to prevent this from happening again.
This never ended in a release, however it would have been a security vulnerability capable of a a DoS, see https://cwe.mitre.org/data/definitions/400.html.