-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make status file names consistent #37532
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
Issues and PRs related to native addons.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Feb 27, 2021
richardlau
approved these changes
Feb 27, 2021
cjihrig
approved these changes
Feb 27, 2021
tniessen
approved these changes
Feb 28, 2021
jasnell
approved these changes
Mar 1, 2021
Landed in 978594c |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 1, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: nodejs#37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
lpinca
pushed a commit
to lpinca/node
that referenced
this pull request
Mar 2, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: nodejs#37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 2, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: #37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: #37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the test/addons directory has a status file of
addon.status rather than addons.status. Make it consistent with other
directories.