Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise method text in async_hooks.md #36736

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 2, 2021

Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jan 2, 2021
@RaisinTen

This comment has been minimized.

doc/api/async_hooks.md Outdated Show resolved Hide resolved
doc/api/async_hooks.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Jan 5, 2021

@nodejs/documentation

Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

PR-URL: nodejs#36736
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 7, 2021

Landed in 67c8e2b

@Trott Trott merged commit 67c8e2b into nodejs:master Jan 7, 2021
@Trott Trott deleted the ah-method branch January 7, 2021 06:55
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

PR-URL: #36736
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

PR-URL: #36736
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants