-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Revise Github to GitHub #36359
doc: Revise Github to GitHub #36359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this should be added to the Markdown linter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to things under deps
should be upstreamed first, in this case to https://github.com/nodejs/node-inspect/
All right. I have created a pull request to |
It does! Just not in the |
It has to be landed and then put in a release so it may be a while. I don't think we want to float a patch for this. I'm going to close this because this will have to come through a |
I am sorry for my unknown. Thank you. |
The |
We typically wait for them to do a release. |
Revise Github to GitHub.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes