doc: stream write(chunk, encoding, cb) encoding can be null #35372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
The targeted subsystem in the commit message should be |
dev-script
changed the title
dev-script
changed the title
I have done changes. please review |
|
Any falsy value for the node/lib/internal/streams/writable.js Lines 293 to 294 in ee9e3e7 Not sure if it is ok to add only |
aduh95
approved these changes
Nov 8, 2020
aduh95
added
the
author ready
aduh95
force-pushed
the
doc/stream-write-encoding
branch
from
d4a718d
to
934faa0
Compare
In stream write encoding can be null. Fixes: nodejs#33715 PR-URL: nodejs#35372 Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
force-pushed
the
doc/stream-write-encoding
branch
from
934faa0
to
caa5a05
Compare
|
Landed in caa5a05 |
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
In stream write encoding can be null. Fixes: #33715 PR-URL: #35372 Reviewed-By: Antoine du Hamel <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
In stream write encoding can be null. Fixes: #33715 PR-URL: #35372 Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
In stream write encoding can be null. Fixes: #33715 PR-URL: #35372 Reviewed-By: Antoine du Hamel <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
In stream write encoding can be null. Fixes: #33715 PR-URL: #35372 Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stream write encoding can be null.
Fixes: #33715
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes