Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,doc: fix grammar due to missing 'is' #34897

Closed
wants to merge 1 commit into from
Closed

src,doc: fix grammar due to missing 'is' #34897

wants to merge 1 commit into from

Conversation

wjabbour
Copy link
Contributor

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 24, 2020
@wjabbour
Copy link
Contributor Author

wjabbour commented Aug 24, 2020 •
edited
Loading

should've probably read 'static binding_data_name field that is based on a'

addaleax pushed a commit that referenced this pull request Aug 26, 2020
@wjabbour @addaleax
src,doc: fix grammar due to missing 'is'
0f9650b 
PR-URL: #34897
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax
Copy link
Member

Landed in 0f9650b

@addaleax addaleax closed this Aug 26, 2020
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@wjabbour @richardlau
src,doc: fix grammar due to missing 'is'
bcc1d43 
PR-URL: #34897
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
This was referenced May 27, 2022
Open
Open
@137717unity 137717unity mentioned this pull request May 27, 2022
Open
@baby636 baby636 mentioned this pull request May 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 27, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 27, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wjabbour @addaleax @fhinkel @jasnell @lpinca @devnexen @nodejs-github-bot