test: split up buffer tests for reliability #3323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, CI looks happy minus a few unrelated flaky tests LGTM |
|
LGTM |
|
thanks for making the change. LGTM |
|
Landed in 7d94611 |
Trott
added a commit
that referenced
this pull request
Oct 13, 2015
The Pi 1's in CI don't always fail on the buffer.toString() tests. But they time out sometimes, so let's split the tests up so they don't. PR-URL: #3323 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed By: Trevor Norris <[email protected]>
|
LTS? /cc @jasnell |
|
Might be worthwhile. |
This was referenced Oct 27, 2015
Trott
added a commit
that referenced
this pull request
Oct 28, 2015
The Pi 1's in CI don't always fail on the buffer.toString() tests. But they time out sometimes, so let's split the tests up so they don't. PR-URL: #3323 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed By: Trevor Norris <[email protected]>
|
Landed in v4.x-staging in a8425ab |
Trott
added a commit
that referenced
this pull request
Oct 29, 2015
The Pi 1's in CI don't always fail on the buffer.toString() tests. But they time out sometimes, so let's split the tests up so they don't. PR-URL: #3323 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3287 made it so that the Pi 1's in CI didn't always fail on the buffer.toString() tests. But they still time out sometimes, so let's split them up a bit more so they don't timeout.
Ref: #3287 (comment)