-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: assign missing deprecation code #33109
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Lau <[email protected]>
nodejs-github-bot
added
deprecations
Issues and PRs related to deprecations.
doc
Issues and PRs related to the documentations.
labels
Apr 27, 2020
Merged
addaleax
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to fast-tracking
BethGriggs
approved these changes
Apr 27, 2020
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #33109 Refs: #32807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Landed in 76ba950 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #33109 Refs: #32807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #33109 Refs: #32807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #33109 Refs: #32807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #33109 Refs: #32807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #33109 Refs: #32807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecations
Issues and PRs related to deprecations.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #32807
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes