Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: delete CallbackInfo when cleared from cleanup hook #32405

Closed
wants to merge 1 commit into from
Closed

src: delete CallbackInfo when cleared from cleanup hook #32405

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fixes: #32400

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Mar 21, 2020
@addaleax addaleax mentioned this pull request Mar 21, 2020
Closed
mmarchini
mmarchini approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will run ASAN tests tomorrow to confirm, but I think it should fix it. Thank you!

@addaleax
Copy link
Member Author

@mmarchini Fwiw, I could reproduce the leak reported by ASAN with valgrind, and valgrind doesn’t report it anymore :)

@addaleax addaleax mentioned this pull request Mar 21, 2020
Closed
3 tasks
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29968/

mmarchini pushed a commit that referenced this pull request Mar 23, 2020
@addaleax @mmarchini
src: delete CallbackInfo when cleared from cleanup hook
678e1be 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mmarchini
Copy link
Contributor

Landed in 678e1be

@mmarchini mmarchini closed this Mar 23, 2020
@addaleax addaleax deleted the buffer-callback branch March 23, 2020 18:11
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@addaleax @MylesBorins
src: delete CallbackInfo when cleared from cleanup hook
bd998bc 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@addaleax @MylesBorins
src: delete CallbackInfo when cleared from cleanup hook
2fe351f 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
src: delete CallbackInfo when cleared from cleanup hook
7aa2ee2 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchini mmarchini mmarchini approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible undefined behavior on buffer's CallbackInfo
7 participants
@addaleax @nodejs-github-bot @mmarchini @jasnell @targos @cjihrig @gengjiawen