zlib: align with streams #32220
Closed
zlib: align with streams #32220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
added
stream
- Ensure automatic destruction only happens after both 'end' and 'finish' has been emitted through autoDestroy. - Ensure close() callback is always invoked. - Ensure 'error' is only emitted once.
ronag
force-pushed
the
zlib-align-w-streams2
branch
from
eb857ea
to
f9dfae6
Compare
4 tasks
ronag
commented
Mar 12, 2020
| @@ -260,8 +263,7 @@ function ZlibBase(opts, mode, handle, { flush, finishFlush, fullFlush }) { | |||
| } | |||
| } | |||
|
|
|||
| Transform.call(this, { autoDestroy: false, ...opts }); | |||
| this._hadError = false; | |||
There was a problem hiding this comment.
We could keep _hadError for compat if necessary.
addaleax
approved these changes
Mar 12, 2020
|
@nodejs/zlib |
mcollina
reviewed
Mar 13, 2020
BridgeAR
reviewed
Mar 17, 2020
|
It would be good to get another review. I would like to get this into the next v13.x release, if this is ready. |
ronag
added
the
author ready
mcollina
reviewed
Mar 19, 2020
|
Landed in a940143 |
ronag
added a commit
that referenced
this pull request
Mar 19, 2020
- Ensure automatic destruction only happens after both 'end' and 'finish' has been emitted through autoDestroy. - Ensure close() callback is always invoked. - Ensure 'error' is only emitted once. PR-URL: #32220 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
FYI @BridgeAR |
|
Hey @ronag, this doesn't land cleanly on v13.x, should it be backported? |
4 tasks
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 19, 2020
- Ensure automatic destruction only happens after both 'end' and 'finish' has been emitted through autoDestroy. - Ensure close() callback is always invoked. - Ensure 'error' is only emitted once. PR-URL: nodejs#32220 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Backport-PR-URL: nodejs#32371
|
It appears that as a result of this PR, const { Inflate } = require('zlib');
new Inflate().close(console.error);Prints nothing in 543c046 and I don't know whether this is expected behavior and/or whether the docs should be clearer (either about when to call |
addaleax
added
semver-major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'end' and 'finish' has been emitted through autoDestroy.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes