Break out platform delegate #30324
Closed
Break out platform delegate #30324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
laverdet
force-pushed
the
platform-delegate
branch
from
8623e9a
to
01976b5
Compare
|
For posterity previous inline comments and responses are here: laverdet@8623e9a |
addaleax
approved these changes
Nov 7, 2019
addaleax
reviewed
Nov 7, 2019
|
Can you add a cctest for this? (I think using a |
lundibundi
reviewed
Nov 7, 2019
bnoordhuis
reviewed
Nov 7, 2019
bnoordhuis
approved these changes
Nov 12, 2019
Adds a new abstract class for module authors and embedders to register arbitrary isolates with `node::MultiIsolatePlatform`.
laverdet
force-pushed
the
platform-delegate
branch
from
32dae59
to
5164b20
Compare
addaleax
added
the
semver-major
|
Now that this has definitely become semver-major this needs another @nodejs/tsc review… |
joyeecheung
approved these changes
Nov 14, 2019
addaleax
added
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Nov 20, 2019
Adds a new abstract class for module authors and embedders to register arbitrary isolates with `node::MultiIsolatePlatform`. PR-URL: #30324 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Landed in c712fb7, thanks for the pull request and please let us know if there’s anything else you need! 🚀 |
addaleax
added
the
v8 platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation from the discussion here: laverdet/isolated-vm#133.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes