Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: use ES6 octal literals for mode #281

Closed
wants to merge 1 commit into from

Conversation

vkurchatkin
Copy link
Contributor

Update docs, comments and code to use ES6 octal literals instead of decimal + comment.

@@ -352,7 +349,7 @@ fs.readFileSync = function(path, options) {
assertEncoding(encoding);

var flag = options.flag || 'r';
var fd = fs.openSync(path, flag, 438 /*=0666*/);
var fd = fs.openSync(path, flag, 0x666);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0o666?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's embarrassing. Thanks for catching this

Partially verified

This commit is signed with the committer’s verified signature.
gsmet’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Update docs, comments and code to use ES6 octal literals
instead of decimal + comment.
@brendanashworth
Copy link
Contributor

Wouldn't this require the --harmony flag to be passed to node? Or will version 1.x have ES6 enabled by default?

@Fishrock123
Copy link
Contributor

@brendanashworth It will have whatever v8 has unflagged. Looks like literal octals are unflagged in the version we are using. https://www.chromestatus.com/features/4930171014479872

@piscisaureus
Copy link
Contributor

lgtm

piscisaureus pushed a commit that referenced this pull request Jan 10, 2015
Update docs, comments and code to use ES6 octal literals instead of
decimal + comment.

PR-URL: #281
Reviewed-by: Bert Belder <[email protected]>
Reviewed-by: Colin Ihrig <[email protected]>
@piscisaureus
Copy link
Contributor

Thanks @vkurchatkin! Landed in 7f9a6c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants