deps: make VC-WIN config generation deterministic #27543
Conversation
This change adds a clean target to the VC-WIN* Makefiles, then adjusts the config generation script to call it before config file generation as well as after. This prevents files from previous configurations from causing make to incorrectly assume the files are up to date.
nodejs-github-bot
added
the
openssl
|
@nodejs/crypto Should this be upstreamed? If not, is there some way to make sure these patches are applied to later OpenSSL updates? |
|
These changes are to the system for integrating OpenSSL into the Node.js build system, not to OpenSSL itself, so they cannot be upstreamed. On the other hand, though, this means that this change will be automatically applied to all future OpenSSL revisions as they happen. |
Oh, I see.... |
|
So this is essentially a @nodejs/build-files change? |
|
Its a bug-fix to the deps/openssl/config/README.md process, the makefiles involved don't get used when node itself builds, they are used to regenerate the openssl conf when openssl is updated. |
BridgeAR
added
the
author ready
|
The CI failures are strange since #27544 contains the same commit and the changes here are not part of the primary build system. |
CI failures are likely unrelated test fragility. Re-running the failed jobs in CI.... |
This change adds a clean target to the VC-WIN* Makefiles, then adjusts the config generation script to call it before config file generation as well as after. This prevents files from previous configurations from causing make to incorrectly assume the files are up to date. PR-URL: nodejs#27543 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 1aa99df |
This change adds a clean target to the VC-WIN* Makefiles, then adjusts the config generation script to call it before config file generation as well as after. This prevents files from previous configurations from causing make to incorrectly assume the files are up to date. PR-URL: #27543 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This change adds a clean target to the VC-WIN* Makefiles, then adjusts
the config generation script to call it before config file generation
as well as after. This prevents files from previous configurations from
causing make to incorrectly assume the files are up to date.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes