-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about mkdtemp() platform differences #26944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good but I do wonder whether a warning would be more clear. I imagine most people will find this after trying to debug this issue for a while rather than before.
@apapirovski I'll add the warning. I think it will be a source of bugs and frustration if it does happen. Most people would never see the warning anyway. |
@apapirovski warning added in #26980. |
CI: https://ci.nodejs.org/job/node-test-pull-request/22024/ EDIT(cjihrig): CI was green. |
PR-URL: nodejs#26944 Fixes: nodejs#26435 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #26944 Fixes: #26435 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #26944 Fixes: #26435 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Fixes: #26435
I'm not sure how strongly anyone feels about this, but I could potentially emit a warning if the provided prefix string ends with X.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes