-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools,doc: standardize RFC name formatting #26727
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants.
Update lint-md.js to lint for "RFC1234" and similar variants that should be written as "RFC 1234".
richardlau
approved these changes
Mar 18, 2019
👍 here to fast track. |
Trott
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Mar 18, 2019
vsemozhetbyt
approved these changes
Mar 18, 2019
Landed in 0a00933...72f5783 |
Trott
added a commit
that referenced
this pull request
Mar 18, 2019
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants. PR-URL: #26727 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Trott
added a commit
that referenced
this pull request
Mar 18, 2019
Update lint-md.js to lint for "RFC1234" and similar variants that should be written as "RFC 1234". PR-URL: #26727 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants. PR-URL: nodejs#26727 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Update lint-md.js to lint for "RFC1234" and similar variants that should be written as "RFC 1234". PR-URL: nodejs#26727 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants. PR-URL: #26727 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Update lint-md.js to lint for "RFC1234" and similar variants that should be written as "RFC 1234". PR-URL: #26727 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
Second commit:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes