Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: fix refresh inside callback #26721

Closed
wants to merge 2 commits into from
Closed

timers: fix refresh inside callback #26721

wants to merge 2 commits into from

Commits on Mar 19, 2019

  1. timers: fix refresh inside callback 

    When `timers.refresh()` is called inside a callback, the timer would
incorrectly end up unrefed and thus not keep the event loop alive.
    @apapirovski
    apapirovski committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    c37a50a View commit details
    Browse the repository at this point in the history

  2. fixup test

    @apapirovski
    apapirovski committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    a70719a View commit details
    Browse the repository at this point in the history