Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: make _read() be called indefinitely if the user wants so #26135

Closed
wants to merge 1 commit into from
Closed

stream: make _read() be called indefinitely if the user wants so #26135

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Fixes: #26097

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mcollina mcollina requested review from mafintosh and lpinca February 15, 2019 16:21
@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2623/pipeline

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Feb 15, 2019
@mcollina mcollina added dont-land-on-v6.x and removed stream Issues and PRs related to the stream subsystem. labels Feb 15, 2019
@lpinca lpinca added the stream Issues and PRs related to the stream subsystem. label Feb 15, 2019
@lpinca
Copy link
Member

lpinca commented Feb 15, 2019 •
edited
Loading

SGTM , is it possible to add a test?

@lpinca
Copy link
Member

lpinca commented Feb 15, 2019

nvm, it's there I'm blind :)

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20836/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019
@mcollina
Copy link
Member Author

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/20860/

@mcollina
Copy link
Member Author

mcollina commented Feb 18, 2019 •
edited
Loading

Benchmark CI (streams): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/290/
Benchmark CI (http): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/291/

@mcollina
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20874/

@mcollina
Copy link
Member Author

@nodejs/build can you take a look why the benchmarking jobs are broken?

@richardlau
Copy link
Member

@nodejs/build can you take a look why the benchmarking jobs are broken?

Issue was reported: nodejs/build#1690

@Trott
Copy link
Member

Trott commented Feb 18, 2019

@nodejs/build can you take a look why the benchmarking jobs are broken?

I've been running benchmarks locally and pasting the results into issues as necessary. It is onerous for sure and I would not blame you at all for waiting until the benchmarking job is fixed. But if you're eager to move forward....

@mcollina
Copy link
Member Author

Here is the one on streams:

$ cat stream-infinite-loop.csv | Rscript benchmark/compare.R
                                                       confidence improvement accuracy (*)   (**)  (***)
 streams/creation.js kind='duplex' n=50000000                         -0.04 %       ±0.89% ±1.18% ±1.54%
 streams/creation.js kind='readable' n=50000000                       -0.16 %       ±0.39% ±0.51% ±0.67%
 streams/creation.js kind='transform' n=50000000                      -0.50 %       ±1.39% ±1.85% ±2.41%
 streams/creation.js kind='writable' n=50000000                       -0.18 %       ±0.86% ±1.14% ±1.49%
 streams/pipe-object-mode.js n=5000000                                 0.08 %       ±0.69% ±0.92% ±1.20%
 streams/pipe.js n=5000000                                             0.32 %       ±0.62% ±0.83% ±1.08%
 streams/readable-bigread.js n=1000                             *     -1.38 %       ±1.30% ±1.74% ±2.30%
 streams/readable-bigunevenread.js n=1000                             -0.29 %       ±0.57% ±0.76% ±1.00%
 streams/readable-boundaryread.js type='buffer' n=2000                 0.14 %       ±1.57% ±2.09% ±2.73%
 streams/readable-boundaryread.js type='string' n=2000                 0.34 %       ±1.87% ±2.49% ±3.24%
 streams/readable-readall.js n=5000                                   -1.00 %       ±1.56% ±2.08% ±2.71%
 streams/readable-unevenread.js n=1000                                -0.07 %       ±0.50% ±0.67% ±0.88%
 streams/writable-manywrites.js n=2000000                              0.10 %       ±0.70% ±0.93% ±1.21%

@mcollina
Copy link
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1746/

@mafintosh
Copy link
Member

LGTM

@mcollina
Copy link
Member Author

This can land when CI gets back online.

@mcollina
Copy link
Member Author

Landed in cd302d7

@mcollina mcollina closed this Feb 28, 2019
@mcollina mcollina deleted the fix-read-infinite-loop branch February 28, 2019 15:12
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@mcollina @addaleax
stream: make _read() be called indefinitely if the user wants so
7612574 
Fixes: #26097

PR-URL: #26135
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
@fjsousa
Copy link

fjsousa commented Apr 9, 2019

Issue #26097 affects node >=10.0.0. Are there any plans of releasing this fix in the next node 10 release?

@mcollina
Copy link
Member Author

mcollina commented Apr 9, 2019

@nodejs/lts would you mind including this in the next semver-patch of v10.x?

BethGriggs pushed a commit that referenced this pull request Jul 9, 2019
@mcollina @BethGriggs
stream: make _read() be called indefinitely if the user wants so
afba5b5 
Fixes: #26097

PR-URL: #26135
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Jul 17, 2019
@mcollina @BethGriggs
stream: make _read() be called indefinitely if the user wants so
044e753 
Fixes: #26097

PR-URL: #26135
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@mafintosh mafintosh mafintosh approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readable stops reading