Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test/common/report.js #25754

Merged
merged 1 commit into from
Jan 30, 2019
Merged

test: refactor test/common/report.js #25754

merged 1 commit into from
Jan 30, 2019

Commits on Jan 30, 2019

  1. test: refactor test/common/report.js 

    - Don't unnecessarily require('../common').
- Eliminate state maintained in tmppath.
- validate() was being used synchronously, but was actually
  asynchronous. Make it synchronous.
- Other misc. drive by cleanup.

PR-URL: nodejs#25754
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
    @cjihrig
    cjihrig committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    c64b1ae View commit details
    Browse the repository at this point in the history