Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set -blibpath: for AIX #25447

Closed
wants to merge 1 commit into from
Closed

build: set -blibpath: for AIX #25447

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

#17604 refactored the gyp files
so that -blibpath: on AIX was only set if node_shared=="true".
Restore the setting for non-shared builds.

Fixes: #25444

cc @nodejs/build-files @nodejs/platform-aix

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
build: set -blibpath: for AIX
36839de 
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444
@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2234/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 11, 2019
@richardlau
Copy link
Member Author

Locally built:

bash-4.4$ dump -X64 -H out/Release/node

out/Release/node:

                        ***Loader Section***
                      Loader Header Information
VERSION#         #SYMtableENT     #RELOCent        LENidSTR
0x00000001       0x0000c49b       0x00027893       0x000000a4

#IMPfilID        OFFidSTR         LENstrTBL        OFFstrTBL
0x00000006       0x0039f7f0       0x0033a49e       0x0039f894


                        ***Import File Strings***
INDEX  PATH                          BASE                MEMBER
0      /usr/lib:/lib:/opt/freeware/lib/pthread/ppc64
1                                    libperfstat.a       shr_64.o
2                                    libstdc++.a         libstdc++.so.6
3                                    libgcc_s.a          shr.o
4                                    libpthreads.a       shr_xpg5_64.o
5                                    libc.a              shr_64.o
bash-4.4$

@richardlau richardlau mentioned this pull request Jan 11, 2019
Closed
@richardlau
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20062/

@richardlau richardlau added the aix Issues and PRs related to the AIX platform. label Jan 11, 2019
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lts-watch-v10.x labels Jan 11, 2019
mhdawson
mhdawson requested changes Jan 11, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this not to land until the discussion on whether its the right thing to do completes.

mhdawson
mhdawson approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ok I see this actually fixes a regression and it was that way before assuming CI passes of course.

@mhdawson
Copy link
Member

@richardlau did you check that the fix that caused the regression was backported to 6.x and 8.x ?

@mhdawson
Copy link
Member

I see it was backported to 6.x and 8.x so never mind.

@richardlau
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20070/

@richardlau
Copy link
Member Author

Resuming again: https://ci.nodejs.org/job/node-test-pull-request/20071/

refack
refack reviewed Jan 12, 2019
View reviewed changes
common.gypi Show resolved Hide resolved
@richardlau
Copy link
Member Author

richardlau commented Jan 14, 2019 •
edited
Loading

Resume: https://ci.nodejs.org/job/node-test-pull-request/20093/ ✔️

@addaleax
Copy link
Member

Landed in bd8d682

@addaleax addaleax closed this Jan 14, 2019
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@richardlau @addaleax
build: set -blibpath: for AIX
bd8d682 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@richardlau @addaleax
build: set -blibpath: for AIX
a4f50a6 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
This was referenced Jan 15, 2019
Closed
Closed
@richardlau
Copy link
Member Author

Backport to v8.x-staging: #25521 (as requested).

@richardlau richardlau added the regression Issues related to regressions. label Jan 15, 2019
This was referenced Jan 16, 2019
Closed
Closed
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@richardlau @BridgeAR
build: set -blibpath: for AIX
5a67471 
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@richardlau richardlau mentioned this pull request Feb 6, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Feb 13, 2019
@richardlau @BethGriggs
build: set -blibpath: for AIX
15756e0 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 19, 2019
@richardlau @BethGriggs
build: set -blibpath: for AIX
13f9356 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@richardlau @BethGriggs
build: set -blibpath: for AIX
5711238 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@richardlau @rvagg
build: set -blibpath: for AIX
156e4c8 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
richardlau added a commit to richardlau/node-1 that referenced this pull request Mar 6, 2019
@richardlau
build: set -blibpath: for AIX
30be5ef 
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#25521
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau richardlau mentioned this pull request Mar 6, 2019
Closed
2 tasks
richardlau added a commit to richardlau/node-1 that referenced this pull request Mar 12, 2019
@richardlau
build: set -blibpath: for AIX
7b34f81 
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#26478
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 15, 2019
@richardlau @BethGriggs
build: set -blibpath: for AIX
c9d21a0 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #26478
PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Mar 15, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Mar 19, 2019
@richardlau @BethGriggs
build: set -blibpath: for AIX
e936907 
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #25521
PR-URL: #25447
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Merged
@beevelop beevelop mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@mhdawson mhdawson mhdawson approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. regression Issues related to regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LIBPATH issue in AIX node binary
7 participants
@richardlau @nodejs-github-bot @mhdawson @addaleax @refack @gireeshpunathil @BethGriggs