Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor common.expectWarning() #25251

Closed
wants to merge 4 commits into from

Commits on Dec 28, 2018

  1. test: rework common.expectWarning()

    The current API is somewhat confusing at times and simpler usage is
    possible. This overloads the arguments further to accept objects
    with deprecation codes as property keys. It also adds documentation
    for the different possible styles.
    
    Besides that it is now going to validate for the code being present
    in case of deprecations but not for other cases. The former validation
    was not consistent as it only validated some cases and accepted
    undefined instead of `common.NoWarnCode`. This check is removed due to
    the lack of consistency.
    
    This also verifies that the warning order is identical to the order
    in which they are triggered.
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    3d579f6 View commit details
    Browse the repository at this point in the history
  2. test: remove common.noWarnCode

    This property was just sugar for `undefined` and did not check much.
    Now that we properly check that a DeprecationWarning requires a code
    we do not have to check that a code is always present.
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    b84f495 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. fixup: fix documentation

    BridgeAR committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    067ced9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a64d10b View commit details
    Browse the repository at this point in the history