Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use global.gc() instead of gc() #25012

Merged
merged 1 commit into from
Dec 15, 2018
Merged

test: use global.gc() instead of gc() #25012

merged 1 commit into from
Dec 15, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 13, 2018

This change is made for consistency, and to remove an eslint-disable comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1923/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 13, 2018
ChALkeR
ChALkeR approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the only place in tests/benchmarks.

LGTM.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2018
@BridgeAR
Copy link
Member

I believe the lite CI is enough here.

@Trott
Copy link
Member

Trott commented Dec 13, 2018 •
edited
Loading

I believe the lite CI is enough here.

I'd prefer we not try to make those judgments. If executable code is changed, CI should be run.

@Trott
Copy link
Member

Trott commented Dec 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19490/

@Trott
Copy link
Member

Trott commented Dec 15, 2018 •
edited
Loading

Now that a few more tests are marked flaky, lets' try another CI: https://ci.nodejs.org/job/node-test-pull-request/19550/

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 15, 2018

Green CI: https://ci.nodejs.org/job/node-test-pull-request/19549/

@cjihrig
test: use global.gc() instead of gc()
715e3c6 
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: nodejs#25012
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig merged commit 715e3c6 into nodejs:master Dec 15, 2018
@cjihrig cjihrig deleted the gc branch December 15, 2018 17:09
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@cjihrig @BethGriggs
test: use global.gc() instead of gc()
ab1801b 
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
test: use global.gc() instead of gc()
f843f9c 
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: nodejs#25012
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@cjihrig @BethGriggs
test: use global.gc() instead of gc()
c9b0a36 
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@cjihrig @BethGriggs
test: use global.gc() instead of gc()
d50330a 
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
test: use global.gc() instead of gc()
5ff8aeb 
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@Trott Trott Trott approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @nodejs-github-bot @BridgeAR @Trott @ChALkeR @Fishrock123 @lpinca @richardlau @BethGriggs