test: move test-cli-syntax to sequential #24907
Conversation
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: nodejs#24403
|
Assuming green CI, I'd like to fast-track this. Collaborators, please 👍 here for fast-tracking. |
|
/ping @joyeecheung @targos on the fast-track request above |
|
Fwiw, I would prefer to mark this as a flaky test…? Moving to sequential is not a solution, and making the failures appear less often is also not a good thing imo… |
I see what you're saying for sure. IMO it fails so frequently that marking it flaky will likely turn our CI more-or-less permanently yellow, which will make us start ignoring flaky tests completely. I'd rather have it less frequently show up as red so at least we take note when it fails. Regardless, the issue for this should definitely remain open until this is sorted out. (I included Refs: and not Fixes:, which you probably noticed.) |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19330/ The AIX failure was still this test. 😱 |
|
AIX again. I'm alarmed that moving to sequential doesn't help AIX much it seems. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19331/ |
|
Maybe moving it to sequential and mark it as flaky? If it still shows up in AIX that much.. |
|
It's green this time. If it continues to fail more than it succeeds on AIX, we can mark it flaky. |
|
Landed in 5011dfe |
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: nodejs#24403 PR-URL: nodejs#24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: #24403 PR-URL: #24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: nodejs#24403 PR-URL: nodejs#24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: #24403 PR-URL: #24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: #24403 PR-URL: #24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of hand. Let's move it to sequential. Refs: #24403 PR-URL: #24907 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: #24403
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes