deps: update llhttp to 1.0.1 #24508
Closed
deps: update llhttp to 1.0.1 #24508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix callback error reporting
|
@indutny sadly an error occured when I tried to trigger a build :( |
sam-github
reviewed
Nov 20, 2018
| @@ -6037,6 +6037,7 @@ int llhttp__internal_execute(llhttp__internal_t* state, const char* p, const cha | |||
| if (error != 0) { | |||
| state->error = error; | |||
| state->error_pos = endp; | |||
| return error; | |||
There was a problem hiding this comment.
It is covered by nodejs/llparse@f6eea30#diff-aa87b56401c951fd0ce18bd3cd5a4e67
cjihrig
approved these changes
Nov 20, 2018
jasnell
approved these changes
Nov 21, 2018
|
Landed in 9d4b214, thank you! |
indutny
added a commit
that referenced
this pull request
Nov 21, 2018
Fix callback error reporting PR-URL: #24508 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
Fix callback error reporting PR-URL: #24508 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Fix callback error reporting PR-URL: #24508 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Fix callback error reporting PR-URL: nodejs#24508 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix callback error reporting
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/http