Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove unnecessary fully qualified names #24452

Merged
merged 1 commit into from
Nov 17, 2018
Merged

crypto: remove unnecessary fully qualified names #24452

merged 1 commit into from
Nov 17, 2018

Conversation

codegagan
Copy link
Contributor

The namespaces were already elevated but the code still had fully qualified names.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Nov 17, 2018
bnoordhuis
bnoordhuis approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.nodejs.org/job/node-test-pull-request/18700/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 17, 2018
@refack
Copy link
Contributor

refack commented Nov 17, 2018 •
edited
Loading

ci.nodejs.org/job/node-test-pull-request/18700 (flake #22339)
Resume: https://ci.nodejs.org/job/node-test-pull-request/18704/ (Flaked with #20750)
Resume: https://ci.nodejs.org/job/node-test-pull-request/18705/ (Flaked with #20750 and #24456)
Resume: https://ci.nodejs.org/job/node-test-pull-request/18706/

Please 👍 to fast-track

@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@refack
Copy link
Contributor

refack commented Nov 17, 2018

Hello @codegagan and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.

@codegagan @refack
crypto: remove unnecessary fully qualified names
efa5bf9 
PR-URL: #24452
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2018
@refack refack merged commit efa5bf9 into nodejs:master Nov 17, 2018
@refack
Copy link
Contributor

refack commented Nov 17, 2018

Congratulations @codegagan on getting promoted by GitHub form:
image
to
image

Hope to see you contributing more in the future.

targos pushed a commit that referenced this pull request Nov 18, 2018
@codegagan @targos
crypto: remove unnecessary fully qualified names
cd03c3d 
PR-URL: #24452
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@codegagan codegagan deleted the node-crypto branch November 18, 2018 11:32
@codegagan
Copy link
Contributor Author

Thankyou @refack for motivation and support.

rvagg pushed a commit that referenced this pull request Nov 28, 2018
@codegagan @rvagg
crypto: remove unnecessary fully qualified names
7c29e9b 
PR-URL: #24452
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@codegagan @refack
crypto: remove unnecessary fully qualified names
b219124 
PR-URL: nodejs#24452
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codegagan @refack @bnoordhuis @addaleax @cjihrig @codebytere @nodejs-github-bot