Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: extract listener check as a function #24303

Closed
wants to merge 1 commit into from
Closed

events: extract listener check as a function #24303

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Nov 11, 2018

As there are multiple funcions checking the argument listener,so extract listener check as a separate function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Nov 11, 2018
@mscdex
Copy link
Contributor

mscdex commented Nov 11, 2018 •
edited
Loading

Benchmark CI shows a performance regression with these changes in the events/ee-once.js benchmark.

@danbev
Copy link
Contributor

danbev commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18739/

@danbev
Copy link
Contributor

danbev commented Nov 19, 2018 •
edited
Loading

Re-run of failing node-test-commit-windows-fanned ✔️

@danbev
Copy link
Contributor

danbev commented Nov 19, 2018

Landed in a3d9168.

@danbev danbev closed this Nov 19, 2018
danbev pushed a commit that referenced this pull request Nov 19, 2018
@ZYSzys @danbev
events: extract listener check as a function
a3d9168 
PR-URL: #24303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ZYSzys ZYSzys deleted the events/checkListener branch November 19, 2018 14:37
targos pushed a commit that referenced this pull request Nov 19, 2018
@ZYSzys @targos
events: extract listener check as a function
6b93582 
PR-URL: #24303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ZYSzys @rvagg
events: extract listener check as a function
dd89cfe 
PR-URL: #24303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@ZYSzys @codebytere
events: extract listener check as a function
d94740d 
PR-URL: #24303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys @refack
events: extract listener check as a function
9f53d0f 
PR-URL: nodejs#24303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@ZYSzys @codebytere
events: extract listener check as a function
be56fb7 
PR-URL: #24303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ZYSzys @mscdex @danbev @fhinkel @jasnell @addaleax @BridgeAR @lundibundi @nodejs-github-bot