Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixing arguments order in assert.strictEqual() #24192

Closed
wants to merge 3 commits into from
Closed

test: fixing arguments order in assert.strictEqual() #24192

wants to merge 3 commits into from

Conversation

ulisesantana
Copy link
Contributor

Certain lines on test/parallel/test-http-1.0.js have the arguments switched around on the assert.strictEqual(). This switch the values in the correct order (calculated value, literal value).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
trivikr
trivikr reviewed Nov 7, 2018
View reviewed changes
test/parallel/test-http-1.0.js Outdated Show resolved Hide resolved
test/parallel/test-http-1.0.js Show resolved Hide resolved
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18455/

@gireeshpunathil
Copy link
Member

failures in smart-os platforms seen yesterday, looks like some infra issues that got fixed.
new CI: https://ci.nodejs.org/job/node-test-pull-request/18481/

@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18501/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2018
pull bot pushed a commit to SimenB/node that referenced this pull request Nov 11, 2018
@ulisesantana @gireeshpunathil
test: fix arguments order in assert.strictEqual()
e201c30 
PR-URL: nodejs#24192
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

landed as e201c30

thank you @ulisesantana for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@ulisesantana @BridgeAR
test: fix arguments order in assert.strictEqual()
b02eed5 
PR-URL: #24192
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@ulisesantana @kiyomizumia
test: fix arguments order in assert.strictEqual()
e706a4b 
PR-URL: nodejs#24192
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@ulisesantana @codebytere
test: fix arguments order in assert.strictEqual()
3f7d7da 
PR-URL: #24192
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@ulisesantana @MylesBorins
test: fix arguments order in assert.strictEqual()
2359273 
PR-URL: #24192
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 9, 2020
Open
Open
Open
Open
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ulisesantana @gireeshpunathil @addaleax @jasnell @lpinca @cjihrig @BridgeAR @trivikr @nodejs-github-bot