Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move error handling code into node_errors.cc #24058

Closed
wants to merge 2 commits into from
Closed

src: move error handling code into node_errors.cc #24058

wants to merge 2 commits into from

Commits on Nov 3, 2018

  1. src: move error handling code into node_errors.cc 

    Move the following code into a new node_errors.cc file and
declare them in node_errors.h for clarity and make it possible
to include them with node_errors.h.

- AppendExceptionLine()
- DecorateErrorStack()
- FatalError()
- OnFatalError()
- PrintErrorString()
- FatalException()
- ReportException()
- FatalTryCatch

And move the following definitions (declared elsewhere than
node_errors.h) to node_errors.cc:

- Abort() (in util.h)
- Assert() (in util.h)
    @joyeecheung
    joyeecheung committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    d8f57b3 View commit details
    Browse the repository at this point in the history

  2. fixup! src: move error handling code into node_errors.cc

    @joyeecheung
    joyeecheung committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    19e2788 View commit details
    Browse the repository at this point in the history