doc: add readable and writable property to Readable and Writable #23933
Conversation
nodejs-github-bot
added
doc
Co-Authored-By: dexterleng <[email protected]>
|
ping @jasnell |
|
@nodejs/streams @nodejs/documentation This could use some reviews. |
There was a problem hiding this comment.
The default value is slightly different, and the meaning as well. writable is true when it's safe to call write(), and readable is true when it's safe to call read().
The problem is that some of the core and ecosystem streams sets readable or writable to false to take into account a delayed open scenario.
@mcollina Could you elaborate? In the constructor of Readable and Writable the properties are both true. |
PR-URL: nodejs#23933 Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 16a2b5c. Thanks for the contribution! 🎉 |
PR-URL: #23933 Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #23933 Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #23933 Reviewed-By: Matteo Collina <[email protected]>
PR-URL: nodejs#23933 Reviewed-By: Matteo Collina <[email protected]>
|
FWIW this landed with |
PR-URL: #23933 Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #23933 Reviewed-By: Matteo Collina <[email protected]>
Issue #21431
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes