test: fix errors in test-buffer-alloc.js #23645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborators, please 👍 here to fast-track. |
This fixes test code that was mistaken landed by me this morning. (Code & Learn rush gone bad.) Sorry. Please fast track.
addaleax
approved these changes
Oct 13, 2018
fhinkel
approved these changes
Oct 13, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2018
This fixes test code that was mistaken landed by me this morning. (Code & Learn rush gone bad.) Sorry. Please fast track. PR-URL: nodejs#23645 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
|
Landed in 401dac3 |
4 tasks
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This fixes test code that was mistaken landed by me this morning. (Code & Learn rush gone bad.) Sorry. Please fast track. PR-URL: #23645 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes