Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove long-deprecated APIs without Isolate* arg #23178

Closed
wants to merge 1 commit into from
Closed

src: remove long-deprecated APIs without Isolate* arg #23178

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 30, 2018 •
edited
Loading

These have been deprecated since 75adde0
(February 2014) and most likely do not see much ecosystem usage
to begin with.

(Currently blocked on the linter fix in #23177)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. blocked PRs that are blocked by other issues or PRs. addons Issues and PRs related to native addons. labels Sep 30, 2018
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1071/pipeline

@addaleax addaleax mentioned this pull request Sep 30, 2018
Closed
2 tasks
@refack

This comment has been minimized.

Sign in to view
@addaleax

This comment has been minimized.

Sign in to view
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label Oct 2, 2018
@addaleax
src: remove long-deprecated APIs without Isolate* arg
9b96464 
These have been deprecated since 75adde0
(February 2014) and most likely do not see much ecosystem usage
to begin with.
@addaleax
Copy link
Member Author

addaleax commented Oct 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17572/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2018
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@addaleax
Copy link
Member Author

addaleax commented Oct 3, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17607/

@addaleax
Copy link
Member Author

addaleax commented Oct 4, 2018

Landed in 3d21245

@addaleax addaleax closed this Oct 4, 2018
addaleax added a commit that referenced this pull request Oct 4, 2018
@addaleax
src: remove long-deprecated APIs without Isolate* arg
3d21245 
These have been deprecated since 75adde0
(February 2014) and most likely do not see much ecosystem usage
to begin with.

PR-URL: #23178
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax deleted the remove-no-isolate branch October 7, 2018 23:13
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@addaleax @jasnell
src: remove long-deprecated APIs without Isolate* arg
5f714ac 
These have been deprecated since 75adde0
(February 2014) and most likely do not see much ecosystem usage
to begin with.

PR-URL: #23178
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @refack @jasnell @lpinca @cjihrig @joyeecheung