worker: remove redundant function call to setupPortReferencing in setupChild
#22298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
reviewed
Aug 13, 2018
|
|
||
| // This test makes sure that we manipulate the references of | ||
| // `parentPort` correctly so that the worker threads will | ||
| // automatically exit when there are no any other references. |
| const { isMainThread, parentPort, Worker } = require('worker_threads'); | ||
|
|
||
| // This test makes sure that we manipulate the references of | ||
| // `parentPort` correctly so that the worker threads will |
| assert.strictEqual(code, 0); | ||
| }), 1); | ||
|
|
||
| worker.on('online', common.mustCall(() => {}, 1)); |
There was a problem hiding this comment.
Nit: the 1 with common.mustCall is obsolete as the default is 1.
addaleax
approved these changes
Aug 13, 2018
lpinca
added
the
author ready
|
This PR needs a rebase against master to avoid the git failure in the CI. |
in `setupChild` There is no need to call `setupPortReferencing` in `setupChild` as which has been called with the same arguments in the `oninit` prototype method of `MessagePort`.
|
@joyeecheung The travis CI is green now. PTAL. |
jasnell
approved these changes
Aug 20, 2018
jasnell
approved these changes
Aug 20, 2018
|
Landed in 3b5c992, thanks for the PR! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Aug 23, 2018
There is no need to call `setupPortReferencing` in `setupChild` as which has been called with the same arguments in the `oninit` prototype method of `MessagePort`. PR-URL: #22298 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
There is no need to call `setupPortReferencing` in `setupChild` as which has been called with the same arguments in the `oninit` prototype method of `MessagePort`. PR-URL: #22298 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
There is no need to call `setupPortReferencing` in `setupChild` as which has been called with the same arguments in the `oninit` prototype method of `MessagePort`. PR-URL: #22298 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to call
setupPortReferencinginsetupChildas which has been called with the same arguments in theoninitprototype method ofMessagePort.make -j4 test(UNIX), orvcbuild test(Windows) passes