-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: show hidden item count #22289
Conversation
This adds the number of hidden items in case INSPECT_MAX_BYTES is exceeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can be specific here and say 'byte(s)' instead of 'item(s)', if you like
@addaleax I thought about that as well but my intention was to keep it in line with all other |
Build is fine after rerunning freebsd |
This adds the number of hidden items in case INSPECT_MAX_BYTES is exceeded. PR-URL: nodejs#22289 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in 755520c 🎉 |
This adds the number of hidden items in case INSPECT_MAX_BYTES is
exceeded.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes