doc: add node-test-commit-custom-suites to docs #21927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vsemozhetbyt
added
doc
lance
approved these changes
Jul 21, 2018
richardlau
reviewed
Jul 21, 2018
COLLABORATOR_GUIDE.md
Outdated
| @@ -229,6 +229,10 @@ is designed to allow validation of changes to the copy of V8 in the Node.js | |||
| tree by running the standard V8 tests. It should be run whenever the | |||
| level of V8 within Node.js is updated or new patches are floated on V8. | |||
|
|
|||
| * [`node-test-commit-custom-suites`](https://ci.nodejs.org/job/node-test-commit-custom-suites/) | |||
| runs tests that are in the `test/internet` directory. Those are not run by the | |||
| other jobs listed here. | |||
There was a problem hiding this comment.
While it is true that the default CI_JS_SUITES parameters to the job run internet the job is intended to run any test(suite) with custom arguments (I think you could even simulate the stress job by passing --repeat to TEST_ARGS).
There was a problem hiding this comment.
I was trying to provide the minimum information to be useful. (I'd like to see pummel added FWIW.) If you have some alternate or additional text, do feel free to add it!
3 tasks
maclover7
reviewed
Jul 22, 2018
COLLABORATOR_GUIDE.md
Outdated
| @@ -229,6 +229,10 @@ is designed to allow validation of changes to the copy of V8 in the Node.js | |||
| tree by running the standard V8 tests. It should be run whenever the | |||
| level of V8 within Node.js is updated or new patches are floated on V8. | |||
|
|
|||
| * [`node-test-commit-custom-suites`](https://ci.nodejs.org/job/node-test-commit-custom-suites/) | |||
| runs tests that are in the `test/internet` directory. Those are not run by the | |||
There was a problem hiding this comment.
Not exactly... how about:
node-test-commit-custom-suites runs tests in user-specified directories with parameters provided by the user as well. Currently used on all node-test-commit jobs to run the default test suite with the --worker flag.
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: nodejs#21909 (comment)
richardlau
approved these changes
Jul 23, 2018
trivikr
approved these changes
Jul 24, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 24, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: nodejs#21909 (comment) PR-URL: nodejs#21927 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in f5a2167 |
targos
pushed a commit
that referenced
this pull request
Jul 26, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: #21909 (comment) PR-URL: #21927 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.
Refs: #21909 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/ping @lance @maclover7