Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] lib,src: replace all C++ promises with JS promises #21879

Closed
wants to merge 1 commit into from
Closed

[v10.x] lib,src: replace all C++ promises with JS promises #21879

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jul 19, 2018 •
edited
Loading

Backport of #20830
/cc @BridgeAR

@BridgeAR @targos
lib,src: replace all C++ promises with JS promises
e637159 
C++ promises can not be properly optimized by V8. They also behave
a tiny bit different than "regular" promises.

PR-URL: nodejs#20830
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benedikt Meurer <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/312/pipeline

@targos targos added promises Issues and PRs related to ECMAScript promises. v10.x and removed promises Issues and PRs related to ECMAScript promises. labels Jul 19, 2018
@targos
Copy link
Member Author

targos commented Jul 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15942/

@targos
Copy link
Member Author

targos commented Jul 20, 2018

@TimothyGu @devsnek @benjamingr

@benjamingr
Copy link
Member

@targos can we be sure there is no performance degradation with this backport to older V8?

@targos
Copy link
Member Author

targos commented Jul 21, 2018

@benjamingr The V8 in 10.x is the same as master.

@targos
Copy link
Member Author

targos commented Jul 24, 2018

Ping

targos pushed a commit that referenced this pull request Jul 24, 2018
@BridgeAR @targos
lib,src: replace all C++ promises with JS promises
9817e40 
C++ promises can not be properly optimized by V8. They also behave
a tiny bit different than "regular" promises.

PR-URL: #20830
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benedikt Meurer <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

Backport-PR-URL: #21879
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos
Copy link
Member Author

targos commented Jul 24, 2018

Landed in 9817e40

@targos targos closed this Jul 24, 2018
@targos targos deleted the backport-20830 branch July 24, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @benjamingr @BridgeAR