stream: prevent 'end' to be emitted after 'error'

[mcollina]

This PR adds _readableState.errorEmitted and add the tracking of it.

Fixes: #6083
See: #20334
See: #20449

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[mcollina]

cc @nodejs/streams @mscdex @addaleax @lpinca resubmitted the PR as semver-major. Let me know.

[mscdex]

I still believe we should not just remove this outright but instead replace it with another event. One possible event I previously suggested was 'close', with stream implementors being able to opt-out if they need to manually emit 'close' (e.g. fs.ReadStream/fs.WriteStream). This one would work well because 'close' has already been working this way in core, as it gets emitted whether there was an 'error' event or not. However, I am not really opposed to using a different event name if need be.

[mscdex]

-1 on this as-is

[mcollina]

@mscdex would you be ok if this was part of #20096? I think it goes in the same direction.

[mscdex]

@mcollina I'm not sure what you mean. The issue you linked to more or less seems to include what I was pretty much saying, however there does not seem to be any PR associated with the issue.

[jasnell]

Ping @mcollina @mscdex ... would like to see resolution on this. What's the next step?

[mcollina]

This will be included in #20096, which @mafintosh and myself are going to talk about at the summit. Also, everybody is welcomed to participate.

[jasnell]

@mcollina ... what's the status on this?

[mcollina]

This can be closed for the moment, it will be fixed with the destroy work @mafintosh has been preparing for some time.