Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: exit on gc unhandled rejection #20097

Closed
wants to merge 6 commits into from
Closed

src: exit on gc unhandled rejection #20097

wants to merge 6 commits into from
+746 −92

Commits on Sep 5, 2018

  1. deps: fix V8_PROMISE_INTERNAL_FIELD_COUNT in features.gypi 

    It should have received a variable. Instead, it was set to a string
that was coerced to a integer later on. This fixes it by correctly
passing through the variable value.
    @BridgeAR
    BridgeAR committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    6ed1985 View commit details
    Browse the repository at this point in the history

  2. src: exit on gc unhandled rejection

    @BridgeAR
    BridgeAR committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    1eef8cf View commit details
    Browse the repository at this point in the history

  3. process: stop rejection loop early 

    This adds a fast path to the unhandledRejections and handledRejections
to actually stop trying to emit something if no hook is attached.
    @BridgeAR
    BridgeAR committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    46b0c97 View commit details
    Browse the repository at this point in the history

  4. process: do not run extra microtasks 

    It is not necessary to run the microtasks when an unhandledRejection
hook is attached.
    @BridgeAR
    BridgeAR committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    5218bb2 View commit details
    Browse the repository at this point in the history

  5. fixup: further doc improvements and add todo 

    fixup: undo deprecation change
    @BridgeAR
    BridgeAR committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    2dfe16a View commit details
    Browse the repository at this point in the history

  6. fixup: address targos comments

    @BridgeAR
    BridgeAR committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    637824f View commit details
    Browse the repository at this point in the history