Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] test: introduce SetUpTestCase/TearDownTestCase #19504

Closed
wants to merge 2 commits into from
Closed

[v9.x backport] test: introduce SetUpTestCase/TearDownTestCase #19504

wants to merge 2 commits into from

Commits on Mar 21, 2018

  1. test: introduce SetUpTestCase/TearDownTestCase 

    This commit add SetUpTestCase and TearDownTestCase functions that will
be called once per test case. Currently we only have SetUp/TearDown
which are called for each test.

This commit moves the initialization and configuration of Node and V8 to
be done on a per test case basis, but gives each test a new Isolate.

PR-URL: nodejs#18558
Reviewed-By: Ben Noordhuis <[email protected]>
    @danbev
    danbev committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    1474d9f View commit details
    Browse the repository at this point in the history

  2. test: remove NodeTestFixture from Env constructor 

    PR-URL: nodejs#18558
Reviewed-By: Ben Noordhuis <[email protected]>
    @danbev
    danbev committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    30090a3 View commit details
    Browse the repository at this point in the history